Skip to content

fix/review compliance #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

fix/review compliance #241

merged 4 commits into from
Apr 10, 2025
+181 −156

Conversation

@monyarm
Copy link
Contributor

@monyarm monyarm commented Apr 10, 2025

  • refactor(*): Review Compliance
  • feat(utils/coda): Replace updateOrInsertRow with upsertRow

@monyarm monyarm force-pushed the fix/review-compliance branch from df7bb3c to e747d0d Compare April 10, 2025 12:50
PetarKirov
PetarKirov reviewed Apr 10, 2025
View reviewed changes
PetarKirov
PetarKirov reviewed Apr 10, 2025
View reviewed changes
PetarKirov
PetarKirov reviewed Apr 10, 2025
View reviewed changes
PetarKirov
PetarKirov approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my comments, nice work!

@PetarKirov PetarKirov enabled auto-merge (squash) April 10, 2025 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

Thanks for your Pull Request!

Below you will find a summary of the cachix status of each package, for each supported platform.

package x86_64-linux x86_64-darwin aarch64-darwin
cachix ❌ build failed ❌ build failed ❌ build failed
dcd ✅ cached 🚫 not supported 🚫 not supported
dmd ✅ cached 🚫 not supported 🚫 not supported
dscanner ✅ cached 🚫 not supported 🚫 not supported
dub ✅ cached ✅ cached ✅ cached
folder-size-metrics ✅ cached 🚫 not supported 🚫 not supported
foundry ✅ cached ✅ cached ✅ cached
geth ✅ cached 🚫 not supported ✅ cached
ldc ✅ cached 🚫 not supported 🚫 not supported
lido-withdrawals-automation ✅ cached ✅ cached ✅ cached
mcl ✅ cached 🚫 not supported 🚫 not supported
mev-boost ✅ cached 🚫 not supported 🚫 not supported
nethermind ✅ cached 🚫 not supported 🚫 not supported
nimbus ✅ cached 🚫 not supported 🚫 not supported
nix ❌ build failed ❌ build failed ❌ build failed
nix-eval-jobs ❌ build failed ❌ build failed ❌ build failed
nix-fast-build ❌ build failed ❌ build failed ❌ build failed
pyroscope ✅ cached ✅ cached ✅ cached
random-alerts ✅ cached ✅ cached ✅ cached
rustToolchain ✅ cached ✅ cached ✅ cached
secret ✅ cached 🚫 not supported ✅ cached
serve-d ✅ cached 🚫 not supported 🚫 not supported
terraform ✅ cached 🚫 not supported 🚫 not supported
terranix ✅ cached 🚫 not supported 🚫 not supported
validator-ejector ✅ cached 🚫 not supported 🚫 not supported
web3signer ✅ cached 🚫 not supported 🚫 not supported

@PetarKirov PetarKirov merged commit e7d25b7 into main Apr 10, 2025
23 checks passed
@PetarKirov PetarKirov deleted the fix/review-compliance branch April 10, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetarKirov PetarKirov PetarKirov approved these changes

@MartinNikov MartinNikov MartinNikov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@monyarm @PetarKirov @MartinNikov